-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update dependencies and add dart_code_linter #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀 weird that now we have to use double quotes for yaml
- avoid_returning_null | ||
- avoid_returning_null_for_future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This rule is removed in Dart 3.3.0; it is no longer functional.
Both rules say this in the docs
https://dart.dev/tools/linter-rules/avoid_returning_null
onBackground: const Color(0xffadadad), | ||
background: const Color(0xfff7fafd), | ||
onSurface: const Color(0xffadadad), | ||
surface: const Color(0xfff7fafd), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have to delete background and onBackground?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onBackground
and background
is deprecated in the latest version
https://api.flutter.dev/flutter/material/ColorScheme/onBackground.html
⭐ Feature
✏️ Description:
Updated package dependencies and flutter version.
Fixed deprecated classes from latest flutter version and added dart_code_linter as code analyzer